New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create jurisprudence.csl #5856
Create jurisprudence.csl #5856
Conversation
Suitable for Jurisprudence – a journal published by Charles University, Faculty of Law.
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. 2 tests failedjurisprudencs: may not have any unused macros
jurisprudencs: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")
Please check the test report for details. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: jurisprudence.csl (new)HANCKÉ, B. – RHODES, M. – THATCHER, M. (eds). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York 2007.; CSL search by example. In: Citation Style Editor [online]. 2012. Dostupné na <http://editor.citationstyles.org/searchByExample/>. |
Isn't the automatic "re-indent" commit (92e3331) wrong? It replaced |
The re-indenter does more than re-indent, it also normalizes entities, it has always done this. It isn't necessary to write |
Thanks, I had thought that >< needed to be escaped |
Outside attribute values these do need to be escaped. |
Should I change |
If you don't, the re-indenter will (but only in attribute values) |
@retorquere, the re-indenter has changed just |
@rmzelle, any idea? I haven't changed the re-indenter, so this will be long-standing behavior. |
I don't see anywhere where |
That's my guess, but that'd be pretty strange for a widely used domparser. |
I just ran the original style submission through https://formatter.citationstyles.org/ (in Firefox), and it doesn't touch either |
Damn, that means it's an issue in the |
Personally, I think it's less confusing to leave the entities in both attributes and values, rather than changing them in the one place where they aren't needed |
It's not something I actively do. I have an isolated testcase for xmldom, it's in their serializer. |
Maybe related to xmldom/xmldom#339 ? |
Yeah, they're deeming it desirable behavior (xmldom/xmldom#198). I'll see if this can be either worked around or made configurable. |
Blegh, it's not in a place where I can monkey-patch the problem away. But according to https://www.w3.org/TR/xml/#CleanAttrVals, they are right:
|
Ah, so let's just let it be then? Or post hoc edit ">" back to |
Not the latter, I'd say. Without a proper xml serializer we'd have to resort to regex hacks. I'd sooner patch the xml serializer before applying it. |
@adam3smith thoughts? |
I don't see any reason we shouldn't just leave > alone, yes. |
Looks good, sorry for the delay! |
Suitable for Jurisprudence – a journal published by Charles University, Faculty of Law.