Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jurisprudence.csl #5856

Merged
merged 3 commits into from Feb 22, 2022
Merged

Conversation

OTFlorian
Copy link
Contributor

Suitable for Jurisprudence – a journal published by Charles University, Faculty of Law.

Suitable for Jurisprudence – a journal published by Charles University, Faculty of Law.
@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😟 There are some issues with your submission.

2 tests failed

jurisprudencs: may not have any unused macros

expected: []
     got: ["printers", "quoted"]

(compared using ==)

jurisprudencs: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/jurisprudencs"
     got: "http://www.zotero.org/styles/jurisprudence"

(compared using ==)

Please check the test report for details.

@OTFlorian OTFlorian changed the title Create jurisprudencs.csl Create jurisprudence.csl Jan 17, 2022
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

jurisprudence.csl (new)
HANCKÉ, B. – RHODES, M. – THATCHER, M. (eds). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York 2007.; CSL search by example. In: Citation Style Editor [online]. 2012. Dostupné na <http://editor.citationstyles.org/searchByExample/>.
MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, P. A. – SOSKICE, D. (eds). Varieties of capitalism. The institutional foundations of comparative advantage. New York 2001.; FENNER, M. et al. A data citation roadmap for scholarly data repositories. Scientific Data, 2019, roč. 6, č. 1. DOI: 10.1038/s41597-019-0031-8

CSL search by example. In: Citation Style Editor [online], 2012. Dostupné na <http://editor.citationstyles.org/searchByExample/>.
FENNER, M. et al. A data citation roadmap for scholarly data repositories. Scientific Data, 2019, roč. 6, č. 1, str. 28. DOI: 10.1038/s41597-019-0031-8
HANCKÉ, B. – RHODES, M. – THATCHER, M. (eds). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York 2007. ISBN 978-0-19-920648-3.
MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, P. A. – SOSKICE, D. (eds). Varieties of capitalism. The institutional foundations of comparative advantage. New York 2001, str. 184–213.

@OTFlorian
Copy link
Contributor Author

Isn't the automatic "re-indent" commit (92e3331) wrong? It replaced &gt; with >.

@bwiernik
Copy link
Member

@retorquere

@retorquere
Copy link
Collaborator

The re-indenter does more than re-indent, it also normalizes entities, it has always done this. It isn't necessary to write &gt; inside attribute values.

@bwiernik
Copy link
Member

Thanks, I had thought that >< needed to be escaped

@retorquere
Copy link
Collaborator

Outside attribute values these do need to be escaped.

@OTFlorian
Copy link
Contributor Author

Should I change &lt; to < then?

@retorquere
Copy link
Collaborator

If you don't, the re-indenter will (but only in attribute values)

@OTFlorian
Copy link
Contributor Author

@retorquere, the re-indenter has changed just &gt; to >, without changing the corresponding &lt; to <. It is quite strange.

@retorquere
Copy link
Collaborator

@rmzelle, any idea? I haven't changed the re-indenter, so this will be long-standing behavior.

@bwiernik
Copy link
Member

I don't see anywhere where &gt; is mentioned in the formatter library. So is that coming from the imported XML Parser?

@retorquere
Copy link
Collaborator

That's my guess, but that'd be pretty strange for a widely used domparser.

@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2022

I just ran the original style submission through https://formatter.citationstyles.org/ (in Firefox), and it doesn't touch either &gt; or &lt;.

@retorquere
Copy link
Collaborator

Damn, that means it's an issue in the xmldom package. I'll see if I can create an isolated testcase and submit it there.

@bwiernik
Copy link
Member

Personally, I think it's less confusing to leave the entities in both attributes and values, rather than changing them in the one place where they aren't needed

@retorquere
Copy link
Collaborator

It's not something I actively do. I have an isolated testcase for xmldom, it's in their serializer.

@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2022

Maybe related to xmldom/xmldom#339 ?

@retorquere
Copy link
Collaborator

Yeah, they're deeming it desirable behavior (xmldom/xmldom#198). I'll see if this can be either worked around or made configurable.

@retorquere
Copy link
Collaborator

retorquere commented Jan 23, 2022

Blegh, it's not in a place where I can monkey-patch the problem away. But according to https://www.w3.org/TR/xml/#CleanAttrVals, they are right:

Well-formedness constraint: No < in Attribute Values

@bwiernik
Copy link
Member

bwiernik commented Jan 24, 2022

Ah, so let's just let it be then? Or post hoc edit ">" back to "&gt;"?

@retorquere
Copy link
Collaborator

Not the latter, I'd say. Without a proper xml serializer we'd have to resort to regex hacks. I'd sooner patch the xml serializer before applying it.

@bwiernik
Copy link
Member

@adam3smith thoughts?

@adam3smith
Copy link
Member

I don't see any reason we shouldn't just leave > alone, yes.

@adam3smith adam3smith merged commit e02b500 into citation-style-language:master Feb 22, 2022
@adam3smith
Copy link
Member

Looks good, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants