Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postcss frontend vuln - snyk #1323

Merged
merged 15 commits into from
Nov 17, 2021
Merged

Fix postcss frontend vuln - snyk #1323

merged 15 commits into from
Nov 17, 2021

Conversation

aloftus23
Copy link
Contributor

upgraded postcss to 7.0.36

@aloftus23 aloftus23 self-assigned this Nov 17, 2021
@epicfaace
Copy link
Member

epicfaace commented Nov 17, 2021

I'm not sure if postcss 8 (which fixes all the vulns for this package) will ever work because CRA has not yet updated to support postcss 8 yet -- see facebook/create-react-app#9664 (comment)

@aloftus23
Copy link
Contributor Author

I'm not sure if postcss 8 (which fixes all the vulns for this package) will ever be supported because CRA has not yet updated to support postcss 8 yet -- see facebook/create-react-app#9664 (comment)

Only trying to upgrade to 7.0.36 which removes the vuln from snyk test. Merge conflict is weird ho cause I don't have it locally...getting there

@aloftus23 aloftus23 marked this pull request as ready for review November 17, 2021 21:52
@aloftus23 aloftus23 merged commit 490811b into master Nov 17, 2021
@aloftus23 aloftus23 deleted the postcss-upgrade branch November 17, 2021 22:16
@aloftus23 aloftus23 linked an issue Nov 19, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerabilities: in the frontend directory
3 participants