Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headless option #10

Merged
merged 1 commit into from May 25, 2022
Merged

Add headless option #10

merged 1 commit into from May 25, 2022

Conversation

fkorotkov
Copy link
Contributor

Fixes #9

@fkorotkov fkorotkov requested a review from edigaryev May 23, 2022 20:46
@fkorotkov
Copy link
Contributor Author

I think it's OK to default it to run with graphics for people just trying out tart. Plus setting default in mapstructure is not that trivial as expected.

Or maybe we can call the option Graphics to closer represent how tart calls it internally and not look at how VMWare does it as @trodemaster mentioned in #9. @edigaryev @trodemaster what do you both think?

@trodemaster
Copy link
Contributor

Calling the option headless matches a convention seen in most of the existing packer plugins that use desktop computer hypervisors. As a user having the default show the tart GUI is desirable. Optionally hiding it is nice when doing builds as part of an automation workflow.

@fkorotkov fkorotkov merged commit a1d9ba8 into main May 25, 2022
@fkorotkov fkorotkov deleted the headless-mode branch May 25, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add headless option to tart-cli source
3 participants