Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Retry if the PR is unrebaseable #75

Merged
merged 2 commits into from
May 7, 2021
Merged

Conversation

ddzero2c
Copy link
Contributor

@ddzero2c ddzero2c commented May 6, 2021

Trying to fix issue 72

entrypoint.sh Outdated

if [[ "$REBASEABLE" != "true" || "$i" == "$MAX_RETRIES" ]] ; then
echo "GitHub doesn't think that the PR is rebaseable!"
echo "API response: $pr_resp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not print the response here. It was a CVE https://bugs.chromium.org/p/project-zero/issues/detail?id=2070

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entrypoint.sh Outdated
fi
done

if [[ "$REBASEABLE" != "true" || "$i" == "$MAX_RETRIES" ]] ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no need to check for i value. Not even sure if it's still available here. 🤔

Suggested change
if [[ "$REBASEABLE" != "true" || "$i" == "$MAX_RETRIES" ]] ; then
if [[ "$REBASEABLE" != "true" ]] ; then

Copy link
Contributor Author

@ddzero2c ddzero2c May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it no need to check for i.

e4987e7

@ddzero2c ddzero2c requested a review from fkorotkov May 7, 2021 03:15
@fkorotkov fkorotkov merged commit 1eb6e5e into cirrus-actions:master May 7, 2021
@fkorotkov
Copy link
Member

@ddzero2c thank you for the PR!

xzile pushed a commit to Interfolio/rebase that referenced this pull request Apr 19, 2022
* Retry if the PR is unrebaseable

* Remove useless code

(cherry picked from commit 1eb6e5e)
xzile pushed a commit to Interfolio/rebase that referenced this pull request Apr 19, 2022
* Retry if the PR is unrebaseable

* Remove useless code

(cherry picked from commit 1eb6e5e)
xzile pushed a commit to Interfolio/rebase that referenced this pull request Apr 19, 2022
* Retry if the PR is unrebaseable

* Remove useless code

(cherry picked from commit 1eb6e5e)
cjw6k pushed a commit to SonarSoftwareInc/rebase that referenced this pull request Apr 26, 2022
* Retry if the PR is unrebaseable

* Remove useless code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub doesn't think that the PR is rebaseable!
2 participants