Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): bugs autosquash always set true #103

Merged
merged 2 commits into from Dec 13, 2022

Conversation

adeherysh
Copy link
Contributor

@adeherysh adeherysh commented Jul 30, 2022

Rebase autosquash condition on entrypoint.sh always read as true condition when set to false on input,
cause operator -eq only works for integer comparisons

@adeherysh adeherysh marked this pull request as ready for review July 30, 2022 09:46
@adeherysh
Copy link
Contributor Author

how about this @fkorotkov ?

@@ -100,7 +100,7 @@ git fetch fork $HEAD_BRANCH

# do the rebase
git checkout -b fork/$HEAD_BRANCH fork/$HEAD_BRANCH
if [[ $INPUT_AUTOSQUASH -eq 'true' ]]; then
if [[ $INPUT_AUTOSQUASH == 'true' ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, this is affecting me too.

@fkorotkov fkorotkov merged commit b87d481 into cirrus-actions:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants