Do not differentiate between native and non-native for refined #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hamnis Is this not a binary breaking change for users of circe-refined? The reason native use a newer version was because native required a newer version and did not exist when circe-refined was created, so in a way wasn't binary breaking. |
|
it might be, but do we have to be so strict with regards to binary breakage in a third party integration module? If we are, we should spin it off into an own repo, which has its own release schedule. |
Agree. We should do this for all the circe integrations, same as we did for http4s. |
|
Closing for now. We will spin off refined into a separate repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 0.11.1 for both