vendor: bump cobra to v1.1.1 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
twpayne
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
requested changes
Oct 19, 2020
Might need to use replace directive to enforce v2.2.8 as well. Thinking about it, I noticed that cilium is using v2.3.0, is there anything to worry about? /cc @rolinh @aanm |
twpayne
force-pushed
the
pr/twpayne/bump-cobra
branch
from
9ca542f
to
78c1b60
Compare
gopkg.in/yaml.v2 version 2.3.0 changes the default line wrapping from 80 characters to none. This potentially breaks Kubernetes and Helm. See spf13/cobra#1259 for discussion. Signed-off-by: Tom Payne <tom@isovalent.com>
Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
force-pushed
the
pr/twpayne/bump-cobra
branch
from
78c1b60
to
1ae702e
Compare
|
Thanks for the feedback, PR updated to pin |
rolinh
approved these changes
Oct 19, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cobra 1.1.0 inadvertently included a breaking YAML change affecting
kubectl and helm. See spf13/cobra#1259 for
details.
Signed-off-by: Tom Payne tom@isovalent.com