cmd/bpf2go: test against clang-14 by default #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
clang-14
branch
2 times, most recently
from
1dd5b01
to
ef0f691
Compare
clang-9 is getting difficult to get a hold of on recent distributions. Default to clang-14 for bpf2go tests, but allow CI to still use clang-9. This avoids regressing clang-9 support by for example using a new command line option. Also skip tests that invoke clang from inside the VM, since they tend to be quite slow. Instead, run them when testing on the previous stable version of Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-9 is getting difficult to get a hold of on recent distributions. Default to clang-14 for bpf2go tests, but allow CI to still use clang-9. This avoids regressing clang-9 support by for example using a new command line option.