features: implement probes for StructOps maps and programs #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
reviewed
Jul 22, 2022
lmb
reviewed
Jul 24, 2022
ti-mo
force-pushed
the
tb/struct-ops-probes
branch
from
33579cb
to
1ab1abc
Compare
rgo3
requested changes
Jul 27, 2022
ti-mo
force-pushed
the
tb/struct-ops-probes
branch
2 times, most recently
from
1e40754
to
667f06d
Compare
Remove all variables declared in createMapTypeAttr in favor of writing values directly into a MapCreateAttr. Signed-off-by: Timo Beckers <timo@isovalent.com>
With the libbpf feature probe API being reworked a while back, a probe for StructOps maps was also implemented. Setting an invalid vmlinux type id and checking for ENOTSUPP signals the map's availability. Signed-off-by: Timo Beckers <timo@isovalent.com>
ENOTSUPP means the program type is available. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/struct-ops-probes
branch
from
667f06d
to
40ec2f0
Compare
lmb
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this was never really blocking: #344. Specifying any invalid vmlinux type id when creating a map is enough to get some information other than EINVAL.