elf_reader: Allow strings read-only global data sections #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
requested review from
ti-mo and
lmb
and removed request for
ti-mo
ti-mo
previously requested changes
Jul 20, 2022
dylandreimerink
force-pushed
the
feature/string-global-data
branch
from
f8eb4d2
to
8cb233e
Compare
lmb
reviewed
Jul 21, 2022
In the past we had the limitation that string sections like `.rodata.str1.1` could not not be loaded since clang/LLVM doesn't provide BTF information for such sections. In cilium#675 we lifted the requirement to have BTF information for global data sections. This means that we can now also allow string sections to be loaded as global data. All facilities to do so are already in place, this commit just removes the check for references to sections with the `SHF_STRINGS` flag set. Fixes: cilium#741 Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/string-global-data
branch
from
8cb233e
to
6c8d388
Compare
lmb
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we had the limitation that string sections like
.rodata.str1.1could not not be loaded since clang/LLVM doesn'tprovide BTF information for such sections. In #675 we lifted the
requirement to have BTF information for global data sections. This means
that we can now also allow string sections to be loaded as global data.
All facilities to do so are already in place, this commit just removes
the check for references to sections with the
SHF_STRINGSflag set.Fixes: #741
Signed-off-by: Dylan Reimerink dylan.reimerink@isovalent.com