features: centralize error semantics, remove maxMiscType, etc. #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this function is a relatively lean wrapper around setting ins.Offset and doesn't do any particular sanity checking to see if e.g. the offset is within bounds, it's not clear what benefit this provides being part of the exported API. As its only use is within the test suite where the instruction stream is known up front, remove the function for now. Signed-off-by: Timo Beckers <timo@isovalent.com>
As miscTypes cannot be specified by the caller, there's no strong reason to input check these arguments. Calls to createMiscProbeAttr() will fail when the miscTyps is not implemented anyway. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
The error string was changed when it was exported in cilium#541 and is potentially ambiguous. Signed-off-by: Timo Beckers <timo@isovalent.com>
lmb
reviewed
Feb 17, 2022
I keep reading the switch in FixupReferences wrong: I always assume that any instruction with a reference will trigger the unsatisfied reference error. This isn't the case since only the program reference switch cases execute a break. Make the whole thing easier to understand by copying the error message into two places.
lmb
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed per commit.
These are some changes I'd liked to see in #541, but did not have the bandwidth to review at the time. apologies.
The function documentation was getting a bit repetitive to my liking, I think it fits better in the package doc, with any exceptions (currently none) documented on the function in question.
I don't feel very strongly about
ErrUnsatisfiedProgramReference, but it's potentially confusing during troubleshooting, so IMO it's better to be specific.