New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance kernel version detection by using uname #1399
Conversation
* Refactored the detectKernelVersion function to not solely rely on vdsoVersion. Added a fallback mechanism using the KernelRelease function, which utilizes the uname system call to get the kernel release string. Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
We moved away from You can always set |
@brycekahle I added this as a fallback mechanism. Setting the flag manually v/s at least having something to get the kernel version 🤷🏼♂️ |
I understand, but this is more code to maintain for what sounds like a very narrow use case (vDSO disabled). See the code we removed in #500 for the old parsing code. Maybe the maintainers feel differently, but my vote is to not add more maintenance burden. |
I can see why the team took that decision. I was using Tetragon, and it isn't working with vDSO disabled, so I was trying to work around that somehow. I don't program using eBPF so I don't know how to set this up using some external Tetragon config, if possible. |
I agree with Bryce, we've been down this path and it's not very pretty. Out of curiosity, why do you have vDSO disabled? It'll cause a pretty massive slowdown for e.g. time related syscalls. |
Indeed, it's not pretty, but that is just a backup option in case vdso is disabled. It is not reducing any functionality, just enhancing it. It does not break anything. I have vDSO disabled to tap into time syscalls. This would help in debugging unreproducible builds, so that's the reason behind it. |
Discussed this with @ti-mo, we're not going to bring back uname parsing. That said, I think we should allow running without the vDSO. In fact, the current version of the library shouldn't really rely on the vDSO any more since fbff7db Can you check which version of the library you are using at the moment? My guess is that you don't have the commit above. If that isn't true, please open a bug report that includes the error you are seeing and which version of the library you are using. We might be able to work around this in some other fashion. |
@lmb Nope, it still doesn't work, I'm using Tetragon's latest ci images, and they have that particular commit.
|
I had
vDSO
disabled for tapping into some syscalls, so this is something good to have.