Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous test fixes #1386

Merged
merged 2 commits into from
Mar 26, 2024
Merged

miscellaneous test fixes #1386

merged 2 commits into from
Mar 26, 2024

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Mar 21, 2024

cmd/bpf2go: don't require internet connection in tests

Disable the checksum db and the module proxy. They aren't needed for tests
and disabling means we don't need internet access.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

link: disable uprobe tests on v4.9

Running v4.9 in vimto, trying to create a perf event via perf_event_open 
returns EIO. I've tracked this down to a check in uprobe_register:

    if (!inode->i_mapping->a_ops->readpage &&
!shmem_mapping(inode->i_mapping))
       return -EIO;

See
https://elixir.bootlin.com/linux/v4.9.337/source/kernel/events/uprobes.c#L880

My hunch is that this is related to how vimto sets up the overlayfs mount:
if the probed binary is below the overlayfs the setup fails.

Instead of fixing vimto, stop testing these code paths on v4.9. That kernel 
is already EOL so there is not much use in investing more time.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

lmb and others added 2 commits March 21, 2024 15:50
Disable the checksum db and the module proxy. They aren't needed for
tests and disabling means we don't need internet access.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Running v4.9 in vimto, trying to create a perf event via perf_event_open
returns EIO. I've tracked this down to a check in uprobe_register:

    if (!inode->i_mapping->a_ops->readpage && !shmem_mapping(inode->i_mapping))
        return -EIO;

See https://elixir.bootlin.com/linux/v4.9.337/source/kernel/events/uprobes.c#L880

My hunch is that this is related to how vimto sets up the overlayfs mount: if
the probed binary is below the overlayfs the setup fails.

Instead of fixing vimto, stop testing these code paths on v4.9. That kernel
is already EOL so there is not much use in investing more time.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb changed the title miscallaneous test fixes miscellaneous test fixes Mar 21, 2024
@lmb
Copy link
Collaborator Author

lmb commented Mar 21, 2024

Broken out from #1321

@lmb lmb marked this pull request as ready for review March 22, 2024 10:00
@lmb lmb requested review from mmat11 and a team as code owners March 22, 2024 10:00
@lmb lmb merged commit 73b877d into cilium:main Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant