CI: tidy up golangci-lint #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
The errcheck linter causes too many false positives to be useful. For example, running the upstream errcheck binary flags a ton of "unchecked" defer Close() calls which are probably filtered out by golangci-lint. As an appeal to authority, Cilium proper doesn't have errcheck enabled either. And the author of the high quality staticcheck has said that implementing errcheck without a high false positive rate is not possible. Just disable the linter. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
structcheck was obsoleted a while ago. Remove the obsolete exclude rules. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: output line numbers from golangci-lint
CI: remove errcheck linter
CI: remove obsolete structcheck rules