sys: small cleanups #1154
Merged
sys: small cleanups #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My recent changes to the kernel packaging format broke the generate-btf target. Fix the invocation to work against current builds. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Output the struct being patched just before showing the patch error.
This makes it easier to figure out how the patch went wrong.
Example output:
struct BtfInfo
Struct:"bpf_btf_info"[fields=6]
"btf" Int[unsigned size=64]
"btf_size" Typedef:"__u32"[Int:"unsigned int"]
"id" Typedef:"__u32"[Int:"unsigned int"]
"name" Int[unsigned size=64]
"name_len" Typedef:"__u32"[Int:"unsigned int"]
"kernel_btf" Typedef:"__u32"[Int:"unsigned int"]
Error: output "BtfInfo": patch 1: missing members: frood
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: fix generate-btf
internal/cmd/gentypes: print more helpful error when patch fails
sys: make ENOTSUPP a constant