Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testdata: drop the use of __clang_major__ directive #1151

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

ti-mo
Copy link
Collaborator

@ti-mo ti-mo commented Oct 4, 2023

Following 9139a37 ("llvm: drop 7 and 9 in favor of 11, 14, 17"), drop the use of clang_major in testdata since tested versions of clang now no longer fall within this range.

There's one use remaining in bpf_helpers.h, but that one is also present in the upstream version of the header. Leaving it untouched for now, upstream will remove it at some point.

Following 9139a37 ("llvm: drop 7 and 9 in favor of 11, 14, 17"),
drop the use of __clang_major__ in testdata since tested versions
of clang now no longer fall within this range.

There's one use remaining in bpf_helpers.h, but that one is also present
in the upstream version of the header. Leaving it untouched for now, upstream
will remove it at some point.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo requested a review from lmb October 4, 2023 12:51
@ti-mo ti-mo merged commit 3a926eb into cilium:main Oct 6, 2023
12 checks passed
@ti-mo ti-mo deleted the tb/drop-old-clang-directives branch October 6, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant