Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eks: Don't use spot instances #32553

Merged
merged 2 commits into from
May 16, 2024
Merged

eks: Don't use spot instances #32553

merged 2 commits into from
May 16, 2024

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented May 15, 2024 •
edited

It's causing unnecessary flakes. Money is not a concern so let's not bother using spot instances.

edit: now there are 2 commits:

  • don't use spot instances in eks.
  • don't use preemptible instances in gke.

@michi-covalent
eks: Don't use spot instances
d5da1ef 
It's causing unnecessary flakes. Money is not a concern so let's not
bother using spot instances.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label May 15, 2024
@michi-covalent michi-covalent requested review from a team as code owners May 15, 2024 15:19
@michi-covalent
gke: Don't use preemptible instances
43b3c17 
Similar to EKS, money is not a concern here so let's not bother with
preemptible instances.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested a review from a team as a code owner May 15, 2024 15:30
@michi-covalent
Copy link
Contributor Author

/test

tklauser
tklauser approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

YutaroHayakawa
YutaroHayakawa approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2024
@aanm aanm added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 83e5a9e May 16, 2024
97 of 98 checks passed
@aanm aanm deleted the pr/michi/no-spot-please branch May 16, 2024 08:33
@gandro gandro mentioned this pull request May 21, 2024
Merged
8 tasks
@giorio94
Copy link
Member

@michi-covalent Should we backport this to stable branches as well?

@michi-covalent
Copy link
Contributor Author

oh yeah might as well. let me set backport labels 🚀 🙏

@michi-covalent michi-covalent added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 23, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 23, 2024
Merged
15 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 23, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
Merged
12 tasks
@YutaroHayakawa YutaroHayakawa added the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label May 24, 2024
@YutaroHayakawa YutaroHayakawa removed the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label May 24, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
Merged
10 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 24, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@michi-covalent @giorio94 @tklauser @aanm @YutaroHayakawa @learnitall