Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements to the clustermesh troubleshooting guide #32552

Merged

Conversation

giorio94
Copy link
Member

Improve the clustermesh troubleshooting guide:

  • Document the usage of the newly introduced troubleshoot command to automatically perform sanity checks;
  • Document the retrieval of KVstoreMesh status;
  • Minor changes to the manual verification section:
  • Drop kvstore-specific steps, which apply only when Cilium operates in kvstore mode.

Please refer to the individual commit descriptions for additional details.

I'm marking this PR for backport to all stable versions to match #32336. Marking as backport/author as well to perform the necessary adaptations based on the features available in each version.

Document the usage of the newly introduced troubleshoot command to
investigate connectivity issues towards the clustermesh control plane
(i.e., etcd) in remote clusters.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. backport/author The backport will be carried out by the author of the PR. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 15, 2024
@giorio94 giorio94 requested review from a team as code owners May 15, 2024 14:33
When KVStoreMesh is enabled, this component is responsible for
connecting to the remote clusters. Document the command which
can be used to inspect its status and validate whether connection
are established correctly.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Add a clarification note that the manual steps presented in the guide
are mostly alternative to using the automatic tools described in the
previous section. Additionally, drop the example errors from the TLS
certificates step, as potentially misleading. Users shall leverage
the troubleshoot command instead. Finally, let's fix a couple of typos.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
They apply only when Cilium is configured in kvstore mode, which is
seldom the case these days. The lack of local information is also not
clustermesh specific, and would imply other serious issues. Moreover,
the given checks would not work, and lead to additional confusion when
Cilium operates in CRD mode. Hence, let's just replace them with the
suggestion of checking whether both Cilium agents and KVStoreMesh
(if enabled) are correctly connected to all remote clusters, and the
synchronization has completed.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/clustermesh-troubleshoot-docs branch from 61ece3b to c2d4454 Compare May 15, 2024 14:39
@giorio94
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 16, 2024
Merged via the queue into cilium:main with commit 913e41b May 16, 2024
61 checks passed
@giorio94 giorio94 mentioned this pull request May 16, 2024
3 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 16, 2024
@giorio94 giorio94 mentioned this pull request May 16, 2024
2 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels May 16, 2024
@giorio94 giorio94 mentioned this pull request May 16, 2024
2 tasks
@giorio94 giorio94 added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 16, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport/author The backport will be carried out by the author of the PR. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants