Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv2: filter terminating backends from endpoint selection #32537

Merged

Conversation

harsimran-pabla
Copy link
Contributor

Filtering out backends which are terminating when creating local endpoint state. This will result in quicker route withdrawal if local backends go into terminating state, without waiting for graceful shutdown period of the pods.

This is similar change to PR. Since this change does not need to be backported, created an independent PR for BGPv2.

Filtering out backends which are terminating when creating local
endpoint state. This will result in quicker route withdrawal if local
backends go into terminating state, without waiting for graceful
shutdown period of the pods.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla added release-note/misc This PR makes changes that have no direct user impact. area/bgp labels May 14, 2024
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner May 14, 2024 18:43
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rastislavs
Copy link
Contributor

/test

@harsimran-pabla harsimran-pabla removed the request for review from danehans May 16, 2024 11:56
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 17, 2024
Merged via the queue into cilium:main with commit 9e03698 May 17, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants