Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr/tammach/revert/fib lookup #32512

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Pr/tammach/revert/fib lookup #32512

wants to merge 2 commits into from

Conversation

sayboras
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@sayboras
revert: Remove enforce LXC FIB lookup
626ff3b 
Auto device detection is already enabled by default, so we can revert
this function

> In general, for such setups users should be using `devices=eth+` and
`enableRuntimeDeviceDetection=true`. In future, we should make this
behaviour default, and once done, to revert this patch.

Related: #28264
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
ci: Remove host legacy routing for direct routing
95fdf69 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 13, 2024
@sayboras
Copy link
Member Author

/test

1 similar comment
@sayboras
Copy link
Member Author

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sayboras