Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for logOptions configuration #30513

Closed
wants to merge 4 commits into from
Closed

add doc for logOptions configuration #30513

wants to merge 4 commits into from

Conversation

jjchambl
Copy link

Cilium supports overriding default log options, but the default and allowed values for this configuration are undocumented. This PR attempts to provide a structure and specify the defaults for logging options. I have included the json structure only; cilium also supports key/value pairs, but I don't see how it's possible to have both options in the docs effectively -- potentially one reason they were not included to begin with.

Comments/suggestions welcome. I tried to detail the breadth of options as best I could without getting too granular.

Fixes: #5578

Document Cilium's logOptions and overrides

@jjchambl jjchambl requested review from a team as code owners January 29, 2024 18:02
@maintainer-s-little-helper
Copy link

Commit a404ceb does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 29, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 29, 2024
@maintainer-s-little-helper
Copy link

Commit a404ceb does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commit af86cf3 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commit af86cf3 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commits af86cf3, ef44442, 3bfc815 do not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@jjchambl
Copy link
Author

closing so i can do this right lol

@jjchambl jjchambl closed this Jan 29, 2024
@jjchambl jjchambl deleted the logopt-doc branch January 29, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. kind/community-contribution This was a contribution made by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable log levels in Cillium are completely undocumented
1 participant