Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.11: ci: increase ginkgo kernel test timeout #26921

Merged
merged 1 commit into from
Jul 20, 2023
Merged

v1.11: ci: increase ginkgo kernel test timeout #26921

merged 1 commit into from
Jul 20, 2023

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Jul 19, 2023 •
edited

Increase ginkgo kernel test timeout from 170m to 200m to avoid unnecessary timeouts during test execution.

Examples:

So far no occurances on v1.12 & v1.13. v1.14 and main migrated to GitHub actions that don't set the ginkgo timeout explicitly.

@mhofstetter
ci: increase ginkgo timeout
6e1bae2 
Increase ginkgo kernel test timeout from 170m to 200m to avoid
unnecessary timeouts during test execution.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter requested a review from a team as a code owner July 19, 2023 11:53
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jul 19, 2023
@mhofstetter mhofstetter changed the title ci: increase ginkgo timeout ci: increase ginkgo kernel test timeout Jul 19, 2023
@mhofstetter
Copy link
Member Author

/test

@mhofstetter
Copy link
Member Author

/test-backport-1.11

@pchaigno pchaigno changed the title ci: increase ginkgo kernel test timeout v1.11: ci: increase ginkgo kernel test timeout Jul 20, 2023
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jul 20, 2023
@pchaigno
Copy link
Member

net-next hit flake #22019. I've marked the fix for backport into v1.11 and other stable branches.

Given the timeout bump seems to work, marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 20, 2023
@aditighag aditighag merged commit 303134b into cilium:v1.11 Jul 20, 2023
52 of 53 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/v1.11-increase-ginkgo-kernel-timeout branch July 20, 2023 18:16
@gentoo-root gentoo-root mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhofstetter @pchaigno @aditighag