Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine "K8sDatapathConfig Iptables Skip conntrack for pod traffic test. #23824

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Quarantine "K8sDatapathConfig Iptables Skip conntrack for pod traffic test. #23824

merged 1 commit into from
Feb 16, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Feb 16, 2023 •
edited

Quarantine "K8sDatapathConfig Iptables Skip conntrack for pod traffic" test.

Relates: #22019

@marseel marseel requested review from a team as code owners February 16, 2023 16:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 16, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 16, 2023
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Feb 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 16, 2023
pchaigno
pchaigno approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marseel!

Fixes: #22019

Let's make that into Relates: or similar. We don't want GitHub to close the issue when I merge this PR.

@marseel
Quarantine "K8sDatapathConfig Iptables Skip conntrack for pod traffic…
7112ca7 
…" test.

Related: cilium#22019

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@maintainer-s-little-helper

This comment was marked as resolved.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 16, 2023
@marseel
Copy link
Contributor Author

marseel commented Feb 16, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathVerifier Runs the kernel verifier against Cilium's BPF datapath

Failure Output

FAIL: terminating containers are not deleted after timeout

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@pchaigno
Copy link
Member

The changes are trivial and compile, so let's skip the full end-to-end test suite. Merging.

@pchaigno pchaigno merged commit baa13a8 into cilium:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@dylandreimerink dylandreimerink Awaiting requested review from dylandreimerink dylandreimerink was automatically assigned from cilium/sig-datapath

@christarazi christarazi Awaiting requested review from christarazi christarazi was automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/community-contribution This was a contribution made by a community member. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marseel @pchaigno