Misc. clustermesh debug cleanups #23588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/cleanup
tklauser
added
the
needs-backport/1.13
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' hit: #22019 (93.52% similarity) |
These were probably copied from OnUpdate without modification. Signed-off-by: Tobias Klauser <tobias@cilium.io>
The mutex doesn't need to be held yet while constructing scopedLog. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Pass it as a parameter to k8sServiceHandler instead. Signed-off-by: Tobias Klauser <tobias@cilium.io>
The generated (*Service).deepEqual method already checks the Shared, IncludeExternal and ServiceAffinity members (among others). Thus we can drop the explicit check. Also move the call to s.deepEqual further up as it is computationally less expensive than e.g. comparing FrontendIPs. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/clustermesh-misc-fixes
branch
from
23f867b
to
e629769
Compare
|
/test |
nebril
approved these changes
Feb 10, 2023
tklauser
added
the
ready-to-merge
pchaigno
added
backport-pending/1.13
aanm
added
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.