docs,daemon: Added discouragement warnings for MetalLB to docs and agent #23393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
area/documentation
joestringer
reviewed
Jan 26, 2023
dylandreimerink
force-pushed
the
feature/metallb-notice
branch
from
4196f67
to
2f5b94a
Compare
qmonnet
requested changes
Jan 27, 2023
dylandreimerink
force-pushed
the
feature/metallb-notice
branch
from
2f5b94a
to
d1c2d35
Compare
|
Reading the description, you can probably remove the |
I marked it as such since the original issue is also a release blocker and we would like this message to be there in the 1.13 docs. CC @joestringer |
joestringer
approved these changes
Jan 27, 2023
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
Added warnings explaining that development on the MetalLB based BGP feature has stopped. The feature will not be deprecated in 1.13, so noted that security updates and bugfixes will still be applied. Even though we can't officially deprecate yet, we would like to highly discourage adoption of the old feature unless absolutely necessary. Fixes: cilium#22246 Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/metallb-notice
branch
from
d1c2d35
to
fa62dd4
Compare
|
Alright, its not getting better then this I guess. All reviews are in, CI green except for 2 tests which both hit flake #22019. Marking as ready-to-merge |
dylandreimerink
added
the
ready-to-merge
pchaigno
removed
the
needs-backport/1.13
pchaigno
added
the
backport-pending/1.13
aanm
added
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added warnings explaining that development on the MetalLB based BGP feature has stopped. The feature will not be deprecated in 1.13, so noted that security updates and bugfixes will still be applied.
Even though we can't officially deprecate yet, we would like to highly discourage adoption of the old feature unless absolutely necessary.
Fixes: #22246
Signed-off-by: Dylan Reimerink dylan.reimerink@isovalent.com