Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CNI to 1.2.0 #23319

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Update CNI to 1.2.0 #23319

merged 2 commits into from
Mar 3, 2023

Conversation

michi-covalent
Copy link
Contributor

[ upstream commit a1046bc ]

Run images/scripts/update-cni-version.sh 1.2.0 to update the CNI version.

Ref: https://github.com/containernetworking/plugins/releases/tag/v1.2.0
Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jan 25, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 25, 2023
@michi-covalent michi-covalent mentioned this pull request Jan 25, 2023
Merged
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Jan 25, 2023
@auto-committer auto-committer bot temporarily deployed to release-base-images January 25, 2023 01:46 Inactive
@michi-covalent
Copy link
Contributor Author

/test-backport-1.13

@michi-covalent michi-covalent added the release-blocker/1.13 This issue will prevent the release of the next version of Cilium. label Jan 25, 2023
@michi-covalent michi-covalent marked this pull request as ready for review January 25, 2023 23:21
@michi-covalent michi-covalent requested review from a team as code owners January 25, 2023 23:21
@aanm aanm removed the kind/community-contribution This was a contribution made by a community member. label Jan 27, 2023
@christarazi
Copy link
Member

christarazi commented Feb 1, 2023 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.24-kernel-5.4' hit: #22019 (93.20% similarity)

Job 'Cilium-PR-K8s-1.19-kernel-4.9' failed:

Click to show.

Test Name

K8sAgentPolicyTest Namespaces policies Kubernetes Network Policy by namespace selector

Failure Output

FAIL: Policy cannot be applied

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.19-kernel-4.9 so I can create one.

Job 'Cilium-PR-K8s-1.19-kernel-4.9' failed:

Click to show.

Test Name

K8sAgentIstioTest Istio Bookinfo Demo Tests bookinfo inter-service connectivity

Failure Output

FAIL: Unable to create policy "/home/jenkins/workspace/Cilium-PR-K8s-1.19-kernel-4.9/src/github.com/cilium/cilium/test/k8s/manifests/cnp-specs.yaml"

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.19-kernel-4.9 so I can create one.

Job 'Cilium-PR-K8s-1.19-kernel-4.9' failed:

Click to show.

Test Name

K8sDatapathVerifier Runs the kernel verifier against Cilium's BPF datapath

Failure Output

FAIL: Expected clean target to succeed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.19-kernel-4.9 so I can create one.

@christarazi christarazi temporarily deployed to release-base-images February 1, 2023 16:12 — with GitHub Actions Inactive
@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Feb 1, 2023
Closed
@michi-covalent
Copy link
Contributor Author

michi-covalent commented Feb 1, 2023 •
edited by maintainer-s-little-helper bot

/mlh new-flake Cilium-PR-K8s-1.19-kernel-4.9

👍 created #23521

@michi-covalent
Copy link
Contributor Author

michi-covalent commented Feb 1, 2023 •
edited

/test-1.19-4.9

❌ https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/2570/

@michi-covalent
Copy link
Contributor Author

/test-1.24-5.4

@aanm
Copy link
Member

aanm commented Feb 1, 2023

@michi-covalent it looks that 1.19 failed for the first time with this test. I would suggest to run it five times before merging to detect the potential flake caused by this PR.

@michi-covalent michi-covalent temporarily deployed to release-base-images February 15, 2023 07:57 — with GitHub Actions Inactive
@michi-covalent michi-covalent temporarily deployed to release-base-images February 15, 2023 09:39 — with GitHub Actions Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images February 15, 2023 09:56 Inactive
@michi-covalent
Copy link
Contributor Author

/test-backport-1.13

@michi-covalent michi-covalent temporarily deployed to release-base-images February 15, 2023 10:44 — with GitHub Actions Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images February 15, 2023 10:59 Inactive
@michi-covalent
Copy link
Contributor Author

michi-covalent commented Feb 15, 2023 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.22-kernel-4.9' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from k8s1 to service tftp://[fd04::12]:31986/hello failed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.9 so I can create one.

Job 'Cilium-PR-K8s-1.22-kernel-4.9' hit: #20723 (85.80% similarity)

Job 'Cilium-PR-K8s-1.22-kernel-4.9' has 1 failure but they might be new flake since it also hit 1 known flake: #20723 (85.65)

@michi-covalent
Copy link
Contributor Author

michi-covalent commented Feb 15, 2023 •
edited

test-1.22-4.9: #23317
ci-gke-1.13: time out
ci-aks-1.13: cleanup failed 😢 https://github.com/cilium/cilium/actions/runs/4183267290/jobs/7247415244

@michi-covalent
Copy link
Contributor Author

/test-1.22-4.9

@michi-covalent
Copy link
Contributor Author

/ci-gke-1.13

@michi-covalent
Copy link
Contributor Author

/ci-aks-1.13

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Feb 15, 2023
Closed
@michi-covalent
Copy link
Contributor Author

/test-1.22-4.9

@michi-covalent
Update CNI to 1.2.0
656a909 
[ upstream commit a1046bc ]

Run `images/scripts/update-cni-version.sh 1.2.0` to update the CNI version.

Ref: https://github.com/containernetworking/plugins/releases/tag/v1.2.0
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to release-base-images March 2, 2023 04:23 — with GitHub Actions Inactive
images: update cilium-{runtime,builder}
7433639 
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
@auto-committer auto-committer bot temporarily deployed to release-base-images March 2, 2023 04:39 Inactive
@michi-covalent
Copy link
Contributor Author

/test-backport-1.13

@michi-covalent
Copy link
Contributor Author

michi-covalent commented Mar 2, 2023 •
edited by maintainer-s-little-helper bot

/mlh new-flake Cilium-PR-K8s-1.18-kernel-4.9

👍 created #24138 #24139

@michi-covalent
Copy link
Contributor Author

/test-1.18-4.9

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 2, 2023
@michi-covalent michi-covalent removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Mar 3, 2023
@aanm aanm merged commit ba59356 into v1.13 Mar 3, 2023
@aanm aanm deleted the pr/michi/backport-cni-113 branch March 3, 2023 13:26
@nebril nebril mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.13 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@michi-covalent @christarazi @aanm @gandro @nbusseneau @qmonnet @pchaigno