certloader flake fixes #22995
Merged
certloader flake fixes #22995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
area/CI
github-actions
bot
added
the
kind/community-contribution
kaworu
force-pushed
the
pr/kaworu/certloader-flake-fixes
branch
2 times, most recently
from
3a86408
to
ec778a4
Compare
kaworu
removed
the
kind/community-contribution
rolinh
added
affects/v1.12
gandro
reviewed
Jan 10, 2023
kaworu
force-pushed
the
pr/kaworu/certloader-flake-fixes
branch
from
ec778a4
to
7261acf
Compare
rolinh
added
needs-backport/1.12
needs-backport/1.13
kaworu
force-pushed
the
pr/kaworu/certloader-flake-fixes
branch
from
7261acf
to
89735ef
Compare
christarazi
approved these changes
Jan 11, 2023
gandro
approved these changes
Jan 12, 2023
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' hit: #22019 (94.17% similarity) |
kaworu
force-pushed
the
pr/kaworu/certloader-flake-fixes
branch
from
89735ef
to
2c34c1a
Compare
It has proven flaky and we should be able to rely on the per-test timeout (default to 10m) instead. Fixes cilium#22750 Signed-off-by: Alexandre Perrin <alex@isovalent.com>
This will be used in the following patches for certloader testing. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Before this patch, certloader reloading tests were using a short static timeout after which we would expect the files to be reloaded. Because of that the reloading tests were flaky, as the timeout was too short in some testing environment. Instead of increasing the timeout, this patch make it so we actively wait on the files to be reloaded, looping over a ticker and checking that the reloading condition are met. We're relying on the per-test timeout (default 10m) to bail out. Fixes cilium#21999 Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
force-pushed
the
pr/kaworu/certloader-flake-fixes
branch
from
e2e7579
to
4c0cfeb
Compare
christarazi
added
release-note/ci
|
/test |
|
/ci-datapath |
|
CI passed, marking as |
kaworu
added
the
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
qmonnet
added
backport-pending/1.13
joestringer
moved this from Needs backport from master
to Backport done to v1.12
in 1.12.7
This was referenced Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certloader testing flake fixes implemented as proposed in #22750 (comment)
Fixes: #21999, #22750