Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix：make fsnotify event more readable #22903

Merged
merged 1 commit into from Jan 10, 2023
Merged

fix：make fsnotify event more readable #22903

merged 1 commit into from Jan 10, 2023

Conversation

yulng
Copy link
Contributor

@yulng yulng commented Jan 2, 2023 •
edited

Signed-off-by: yulng wei.yang@daocloud.io

fsnotify/fsnotify#477 and fsnotify release .
so to make fsnotify event more readable

Thanks

@yulng yulng requested a review from a team as a code owner January 2, 2023 07:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 2, 2023
@YutaroHayakawa YutaroHayakawa added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 4, 2023
YutaroHayakawa
YutaroHayakawa approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldelossa
Copy link
Contributor

ldelossa commented Jan 6, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' hit: #22019 (94.82% similarity)

Job 'Cilium-PR-K8s-1.24-kernel-5.4' hit: #22019 (94.17% similarity)

@ldelossa
Copy link
Contributor

ldelossa commented Jan 6, 2023

@yulng can you rebase this branch on latest master? Thanks.

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Jan 6, 2023
Closed
@yulng
make fsnotify event more readable
aac65db 
Signed-off-by: yulng <wei.yang@daocloud.io>
@yulng
Copy link
Contributor Author

yulng commented Jan 7, 2023

@yulng can you rebase this branch on latest master? Thanks.

rebase it and push again just now
thanks

@ldelossa
Copy link
Contributor

ldelossa commented Jan 8, 2023

/test

1 similar comment
@ldelossa
Copy link
Contributor

ldelossa commented Jan 9, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 9, 2023
@aditighag aditighag merged commit 479fb7d into cilium:master Jan 10, 2023
jschwinger233 added a commit to jschwinger233/cilium that referenced this pull request Aug 25, 2023
@jschwinger233
Revert "make fsnotify event more readable"
14fe010 
This reverts commit 479fb7d.

The code changes are not equivalent. For example,
event.Op=fsnotify.Create has different results.

Fixes: cilium#22903

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@jschwinger233 jschwinger233 mentioned this pull request Aug 25, 2023
Merged
pchaigno pushed a commit that referenced this pull request Aug 25, 2023
@jschwinger233 @pchaigno
Revert "make fsnotify event more readable"
d86c148 
This reverts commit 479fb7d.

The code changes are not equivalent. For example,
event.Op=fsnotify.Create has different results.

Fixes: #22903

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@pchaigno
Copy link
Member

This pull request was reverted in #27694 because it introduced a regression in IPsec key rotations.

pippolo84 pushed a commit that referenced this pull request Aug 28, 2023
@jschwinger233 @pippolo84
Revert "make fsnotify event more readable"
dcadad8 
[ upstream commit d86c148 ]

This reverts commit 479fb7d.

The code changes are not equivalent. For example,
event.Op=fsnotify.Create has different results.

Fixes: #22903

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
aditighag pushed a commit that referenced this pull request Sep 1, 2023
@jschwinger233 @aditighag
Revert "make fsnotify event more readable"
e7494f4 
[ upstream commit d86c148 ]

This reverts commit 479fb7d.

The code changes are not equivalent. For example,
event.Op=fsnotify.Create has different results.

Fixes: #22903

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yulng @ldelossa @pchaigno @YutaroHayakawa @aditighag