Revert "install: move cni config management to the agent" #22012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d6346d. This commit is causing issues on AKS where newly-created pods are not getting managed by Cilium for some reason. Reverting to unblock AKS testing. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/cni
|
/test Job 'Cilium-PR-K8s-1.24-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
joestringer
approved these changes
Nov 4, 2022
christarazi
approved these changes
Nov 5, 2022
gandro
approved these changes
Nov 7, 2022
squeed
approved these changes
Nov 7, 2022
gandro
added
the
ready-to-merge
pchaigno
removed
the
ready-to-merge
|
/mlh new-flake Cilium-PR-K8s-1.24-kernel-4.19 👍 created #22019 |
|
CI job k8s-1.16-kernel-4.9 failed with new flake #22019. CI job https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-4.19/774/ failed with some weird new flake #22021, which then caused subsequent tests to fail. Both seem unlikely to be caused by this change as it should only affect pod startup and several tests were successful on both CI jobs. Merging to fix master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts commit 0d6346d.
This commit is causing issues on AKS where newly-created pods are not getting managed by Cilium for some reason. Reverting to unblock AKS testing.
The revert was successfully tested on 3-nodes clusters on AKS (Azure IPAM mode), EKS, and GKE. Each time, the full connectivity tests were run using the CLI.
cc @squeed
Fixes: #21375.
Fixes: #22013.