v1.10 backports 2021-10-28 #17727
Merged
v1.10 backports 2021-10-28 #17727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 339baa8 ] Python sysdump has been deprecated. Ref: https://github.com/cilium/cilium-sysdump Signed-off-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit f1463a8 ] The `pkg/monitor/agent` package mainly performs three tasks: - Managing subscribers of monitor events (such as `cilium monitor` clients or the Hubble observer) - Receiving and broadcasting user-space notifications ("agent events") to the above subscribers. - Polling the perf event ring buffer for datapath notifications and broadcasting them to subscribers. The third task can only be performed once the perf event ring buffer map has been set up by the daemon. However, some subsystems will try to send user-space notifications before the events map has been set up. This often causes an unnecessary log warning to be emitted, which regularly confuses users (see cilium#14146). Fundamentally however, there is no reason to drop user-space events if the datapath is not set up yet. Therefore, this commit splits the monitor agent constructor into two functions: The first one, `NewAgent` initializes the subscriber management and allows user-space notifications to be received early, the second function `AttachToEventsMap` opens the perf event ring buffer to poll datapath events. By splitting up the initialization phase and invoking the constructor earlier, we can avoid the data race in cilium#17167 and we also avoid emitting a unhelpful warning if user-space events are created early. Note: Because subscribers (i.e. Hubble or `cilium monitor` clients) are still attached relatively late, we will still drop early events if there is no one listening for them. This commit does not address that - but instead of emitting a confusing warning that the user cannot do anything about, it will drop the event the same way Cilium up to version 1.8 did. Fixes: cilium#17167 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit f5a1621 ] This change refactors and names 3 of `cmd/daemon` `init` functions so that the order of their execution and what they do is clearer. Signed-off-by: Maciej Kwiek <maciej@isovalent.com> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit 9a9e471 ] This commit does not introduce any functional change, it just renames the package to make it explicit it relates to the egress gateway feature. Fixes: cilium#17389 Signed-off-by: Gilberto Bertin <gilberto@isovalent.com> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.10
kind/backports
|
/test-backport-1.10 Job 'Cilium-PR-K8s-1.18-kernel-4.9' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
jibi
approved these changes
Oct 28, 2021
|
restarting net-next because of infra issue |
|
test-1.16-netnext |
[ upstream commit 7db6998 ] Suppress warning message from helm: warning: skipped value for l7Proxy: Not a table. Signed-off-by: Chen Yaqi <chendotjs@gmail.com> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/v1.10-backport-2021-10-28
branch
from
77e79ba
to
46eb254
Compare
|
repushed to get l4lb to use updated workflow file |
|
/test-backport-1.10 |
|
test-1.16-netnext |
michi-covalent
approved these changes
Nov 4, 2021
pchaigno
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
- daemons: name init functions and have one init daemons: name init functions and have one
init#17616 -- daemons: name init functions and have one init (@nebril)- docs: Fix helm value when deploying pure ipvlan l3 mode docs: Fix helm value when deploying pure ipvlan l3 mode #17708 -- docs: Fix helm value when deploying pure ipvlan l3 mode (@chendotjs)
Those PRs look good to me 👍
|
Previous run had a timeout, retriggering and will check if it's consistent over time. |
|
Weird VirtualBox provisioning error :-/ |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init#17616 -- daemons: name init functions and have oneinit(@nebril)Once this PR is merged, you can update the PR labels via:
or with