Switch from gopkg.in/inotify.v1 to github.com/fsnotify/fsnotify #11138
+14,201
−90,487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fsnotify package suggests to use the github.com/fsnotify/fsnotify package patch, see fsnotify/fsnotify#108. While at it also update to the current master of github.com/fsnotify/fsnotify in order to fix an unsafe pointer conversion for #10133 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
pending-review
release-note/misc
|
test-me-please |
tklauser
changed the title
qmonnet
approved these changes
Apr 27, 2020
aanm
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fsnotify package suggests to use the github.com/fsnotify/fsnotify
package patch, see fsnotify/fsnotify#108.
While at it also update to the current master of
github.com/fsnotify/fsnotify in order to fix an unsafe pointer
conversion for #10133