Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Enable unsafe.Pointer use with checkptr flag in CI test binaries #10783

Closed
wants to merge 1 commit into from
Closed

[WIP] Enable unsafe.Pointer use with checkptr flag in CI test binaries #10783

wants to merge 1 commit into from

Conversation

tklauser
Copy link
Member

DO NOT MERGE, testing only.

Check unsafe.Pointer using the Go 1.14 -d=checkptr compiler option
in CI test builds.

For #10133

@tklauser tklauser added wip area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Mar 31, 2020
@tklauser tklauser requested review from a team as code owners March 31, 2020 13:40
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 31, 2020
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Enable unsafe.Pointer use with checkptr flag in CI test binaries
6742ccb 
DO NOT MERGE, testing only.

Check `unsafe.Pointer` using the Go 1.14 `-d=checkptr` compiler option
in CI test builds.

For #10133

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/test-checkptr-build branch from 1bca593 to 6742ccb Compare March 31, 2020 14:27
@tklauser
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Mar 31, 2020 •
edited

Coverage Status

Coverage decreased (-0.03%) to 45.478% when pulling 6742ccb on pr/tklauser/test-checkptr-build into 60bd7f5 on master.

@tklauser tklauser marked this pull request as draft April 16, 2020 20:02
@stale
Copy link

stale bot commented May 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 16, 2020
@stale
Copy link

stale bot commented May 30, 2020

This issue has not seen any activity since it was marked stale. Closing.

@stale stale bot closed this May 30, 2020
@tklauser tklauser deleted the pr/tklauser/test-checkptr-build branch July 1, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
No open projects
1.8.0
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tklauser @coveralls