Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable log levels in Cillium are completely undocumented #5578

Open
matin-nayob opened this issue Sep 17, 2018 · 9 comments · May be fixed by #30514
Open

Configurable log levels in Cillium are completely undocumented #5578

matin-nayob opened this issue Sep 17, 2018 · 9 comments · May be fixed by #30514
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-report This was reported by a user in the Cilium community, eg via Slack. kind/enhancement This would improve or streamline existing functionality. pinned These issues are not marked stale by our issue bot. sig/agent Cilium agent related.

Comments

@matin-nayob
Copy link

matin-nayob commented Sep 17, 2018

Feature Requests

Hi there,

It would be great if it was possible to configure the log level of Cilium.
By default, it looks like Cilium logs at the Info level, with the --debug argument enabling lower levels of logs.

It would be great if this could be more configurable so that, for example, Cilium would only log Warnings and above.

Thanks


Update 2023-11: We support configurable logging, but it is entirely undocumented. That should be fixed.

@aanm aanm added kind/enhancement This would improve or streamline existing functionality. kind/community-report This was reported by a user in the Cilium community, eg via Slack. labels Sep 17, 2018
@stale
Copy link

stale bot commented Mar 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 31, 2019
@stale
Copy link

stale bot commented Apr 14, 2019

This issue has not seen any activity since it was marked stale. Closing.

@stale stale bot closed this as completed Apr 14, 2019
@jjchambl
Copy link

jjchambl commented Nov 6, 2023

I know this is an old issue, but this seems a simple enough configuration option, so long as Cilium uses log levels correctly already. I've only seen info level logs so far in my limited usage of it (no warning or errors yet), but they occur at a very large volume in our clusters (running 10-20 nodes), which adds up when they're being streamed to a log aggregator like Datadog.

@rolinh rolinh added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Nov 7, 2023
@rolinh rolinh reopened this Nov 7, 2023
@rolinh
Copy link
Member

rolinh commented Nov 7, 2023

The feature request makes sense to me and given the high interest in it, let's keep it open.

@jjchambl
Copy link

jjchambl commented Nov 7, 2023

Happy to help contribute, even if it's just documentation, but haven't worked with the codebase before, so would need some pointers to get started.

@squeed
Copy link
Contributor

squeed commented Nov 10, 2023

I believe this is already complete. However, it is not well documented. We support the Helm value logOptions (or the equivalent ConfigMap flag log-opt) which takes a json blob of configuration or key=value pairs.

I believe you can add the Helm value

logOptions: "level=warning"

and it should work.

@squeed squeed changed the title Configurable log levels in Cillium Configurable log levels in Cillium are completely undocumented Nov 10, 2023
@squeed squeed added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/agent Cilium agent related. labels Nov 10, 2023
@jjchambl
Copy link

That's good news. I'll try it out, if it works I'll look at adding some documentation to that effect.

@jjchambl
Copy link

@squeed have confirmed that your suggestion works. I've set a task for my team to investigate this setting a bit more, and once we've worked with it a bit we'll make a PR into the helm docs repo. Thanks so much!

@jjchambl
Copy link

jjchambl commented Dec 7, 2023

@squeed after further testing, I can't get a value to go through the helm chart that will successfully parse in the Go template (using, for instance a flag like --set logOptions="level=warn"). I need to manually change the configmap to have the correct values.

EDIT: I forgot that Helm has a set-json feature. Using this option worked with the Helm chart. Will be adding a docs PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-report This was reported by a user in the Cilium community, eg via Slack. kind/enhancement This would improve or streamline existing functionality. pinned These issues are not marked stale by our issue bot. sig/agent Cilium agent related.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants