Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to restore terminal when interrupted #195

Closed
wants to merge 1 commit into from

Conversation

nicollet
Copy link

Add option ExitRawOnInterrupt (default off). When turned on, change
disposition of SIGTERM and SIGINT, so that we restore the terminal
mode before exiting. That way, prevents users from having to reset
the terminal themselves most of the time.

Add option ExitRawOnInterrupt (default off). When turned on, change
disposition of SIGTERM and SIGINT, so that we restore the terminal
mode before exiting. That way, prevents users from having to reset
the terminal themselves most of the time.
@chzyer
Copy link
Owner

chzyer commented Apr 17, 2022

Hi, @nicollet
The current version has a bug that does not restore the terminal when receiving a SIGTERM/SIGINT.
But I think adding an option ExitRawOnInterrupt to the configuration is a bad idea because the configuration is changeable.
I have an implementation for fixing it in #200. You can check if that is what you want.
If not, you can reopen it.

@chzyer chzyer closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants