Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new PDF as a Buffer + Upgrade to Muhammara 3.0.0 #237

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

deltazero-cz
Copy link

Hi, I often use PDFs as buffers instead of sync fs files. I've made some small updates in order to be able to create new PDF using buffers (both isBufferSrc and isNewPDF are true). Use as follows:

const buffer = new HummusRecipe(Buffer.from('new'), null, {
    version: 1.6,
    author: 'John Doe',
    title: 'Hummus Recipe',
    subject: 'A brand new PDF'
})
    .createPage('letter-size')
    .endPage()
    .endPDF(); // no callback -> returns a buffer

@julianhille
Copy link
Collaborator

hey there, im the maintainer of muhammara and started implementing recipe directly into muhammara, it would be awesome to get some feedback on this: julianhille/MuhammaraJS#253

@chunyenHuang chunyenHuang mentioned this pull request Jan 19, 2023
@chunyenHuang
Copy link
Owner

Thanks can you help with this PR too #234

I haven't worked for this repo for a while. I am thinking maybe I can add you guys to the admin to merge codes as needed.
I will setup the npm workflow to deploy programmatically once merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants