Use std duration v0.4.x #860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to apply most of 74b087f onto this before its ready for any review |
esheppa
force-pushed
the
use-std-duration-v0.4.x
branch
2 times, most recently
from
61277d5
to
71416a5
Compare
|
Removed |
esheppa
force-pushed
the
use-std-duration-v0.4.x
branch
from
a93aaf9
to
1990ffd
Compare
|
Huh, not sure how I did that but it wasn't on purpose. |
This was referenced Nov 23, 2022
|
Would this be better as three or four seperate PR's? One each for Naive Date, Time, DateTime and potentially DateTime? (I think it may be able to be separated out now that we aren't removing the old code |
|
Probably easier to digest that way! |
|
Closing in favour of #895 (and future PRs for NaiveDate updates and (Naive)DateTime updates) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.