Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for the serde feature #530

Merged
merged 2 commits into from Oct 25, 2021
Merged

Fix warnings for the serde feature #530

merged 2 commits into from Oct 25, 2021

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Jan 29, 2021

#304 introduced the try! macro

@nickelc nickelc changed the title Replace try! macro with question mark Fix warnings for the serde feature Jan 29, 2021
Milo123459
Milo123459 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@Milo123459 Milo123459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Milo123459 Milo123459 merged commit e5dfc1b into chronotope:main Oct 25, 2021
@nickelc nickelc deleted the remove-try branch October 25, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milo123459 Milo123459 Milo123459 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickelc @Milo123459