Fix serde with _option macro bug.
#429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fx-kirin
changed the title
_option macro issue._option macro bug.
|
Thanks for the contribution! Could you add a test that verifies that this fixes something? And you'll need to rebase on top of master to get a build fix. |
quodlibetor
force-pushed
the
fix_option_bug
branch
from
0ffa8cf
to
5c44091
Compare
|
I've added the test and verified. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts_seconds_optionlike macros have not been applied toserialize_some. Some library likebincodecannot deserialize those values because of this problem.To reproduce such bug, i leave a github repository here.
#302