Add note about the TZ environment variable and soundness
#1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1259 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 37 37
Lines 16448 16448
=======================================
Hits 15030 15030
Misses 1418 1418
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
reviewed
Sep 6, 2023
src/lib.rs
Outdated
| //! More importantly POSIX declares modifying the environment in a multi-threaded process as unsafe | ||
| //! (see [rust#27970] for more discussion). | ||
| //! | ||
| //! Since version 4.20 chrono no longer uses `localtime_r` but has a pure-rust solution. So when |
There was a problem hiding this comment.
Maybe we can expand on this a little bit? uses Rust code to query the operating system timezone (via iana-time-zone) and timezone data (DST transitions).
There was a problem hiding this comment.
I gave it a second try. A bit different though, because iana-time-zone is only used as fallback and the time zone data is much more than DST transitions.
pitdicker
force-pushed
the
tz_env_soundness_doc
branch
from
e5ebe8e
to
35e961c
Compare
pitdicker
force-pushed
the
tz_env_soundness_doc
branch
from
35e961c
to
4631889
Compare
|
Now that similar information is included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should say something about this in the docs because it has been a security issue that received a lot of attention, and affected a lot of dependencies.
Alternative to #626.