Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Zulu suffix with %z #1210

Closed
wants to merge 1 commit into from
Closed

Parse Zulu suffix with %z #1210

wants to merge 1 commit into from

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Jul 30, 2023

Fixes #945.

@djc djc requested a review from pitdicker July 31, 2023 09:47
@pitdicker
Copy link
Collaborator

pitdicker commented Jul 31, 2023

@simon04 Thank you for working on this.

Sorry I never updated #945, but I hope to fix offset parsing in a more complete way with #1082, #1083, and a part three that is ready but does not have an open PR yet.

The idea is to allow more options in the %z specifier to allow colons or not, make offset minutes and seconds optional, and to require padding or not.

The specifier to accept Z would become %#z, and would also be usable for formatting.

In #1083 I was careful to only change offsets in a way that is clearly fixing issues. And in part three 3 the format string is extended in a way that does not really change the meaning of the existing specifiers.

But if we accept this PR now, my plans for extensions to the formatting specifier become messy, or noticeable breaking changes.

@pitdicker pitdicker closed this Apr 8, 2024
@pitdicker
Copy link
Collaborator

Closing for the reason mentioned above. Thank you @simon04 for your work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Zulu suffix with %z?
2 participants