upgrade react-hooks-plugin to v4.5.0 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
react-hooks-pluginhas a bug where files with many conditionals are occasionally flagged as calling hooks conditionally. This frequently presents itself in theMetricDefEditorSidePanelcomponent:More details on the bug here: facebook/react#21328
This PR updates to v4.5.0 which should fix the bug.
Steps to verify:
eslint-config-chronographreponpm installnameattribute inpackage.jsonto"eslint-config-chronograph"instead of"@chronograph-pe/eslint-config-chronograph". This is to match the package name incg-webso that symlinking can work.npm linkcg-wegnpm link eslint-config-chronographnpm run lintshould work as expected