-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: FIXING README.md typos #218
Open
moataz2002
wants to merge
1
commit into
chromium:main
Choose a base branch
from
moataz2002:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aarongable
pushed a commit
that referenced
this pull request
Mar 30, 2024
This change ensures the Refinement arrow (↖) is suppressed on Query Tile suggestions. (cherry picked from commit 8f42bca) Bug: b:326668359 Change-Id: Ifabaabccc9c8bbd259508daa262bddd2f016680c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324136 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Reviewed-by: Fred Mello <fredmello@chromium.org> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1265320} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5328869 Cr-Commit-Position: refs/branch-heads/6312@{#218} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 30, 2024
Uploaded by https://ci.chromium.org/b/8765220256784422225 Change-Id: I2cc6ae4cbc8d64175f9916f2024447330c1abaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006865 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#218} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Mar 30, 2024
Roll src/clank in M124 from baedbbf3c2a0 to 55ab5fe74009 Commits rolled: https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/baedbbf3c2a0..55ab5fe74009 Generated by: http://go/bbid/8752469763509722369 Change-Id: I6ab1ce9ccfc4cb254c357abacb97a0995afca3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393123 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#218} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Mar 30, 2024
Change-Id: Ic8b5cf0fb13a8cd68a79334bbd1384483f27fb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245025 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#218} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
It looks like there is a crash when selecting source for ChromeOS with multistream is enabled. Since M125 just branched, I think we should make a change so the capability is not advertised and then fix the issue in M126. (cherry picked from commit b831795) Change-Id: I910bc232dbb9992c8f2b3daa0c313e85e4239d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464329 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1290105} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473523 Cr-Commit-Position: refs/branch-heads/6422@{#218} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Apr 25, 2024
change registering Perf by checking IsOobeDrivePinningScreenEnabled() instead of IsOobeDrivePinningAvailable() because chrome start with SignInprofile in OOBE. Issue introduced by this CL : https://chromium-review.googlesource.com/c/chromium/src/+/4825685 (cherry picked from commit 0ada096) Bug: b:304141131 Change-Id: I4eaef2f57dbdc0862b3629bd89441d4caf2c6266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916007 Commit-Queue: Brahim Chikhaoui <bchikhaoui@google.com> Reviewed-by: Ben Reich <benreich@chromium.org> Reviewed-by: Osama Fathy <osamafathy@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1207007} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4923390 Commit-Queue: Osama Fathy <osamafathy@google.com> Commit-Queue: Ben Reich <benreich@chromium.org> Auto-Submit: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/branch-heads/6045@{chromium#218} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
keyou
pushed a commit
to keyou/chromium
that referenced
this pull request
May 14, 2024
The test is really flaky. We disable it temporarily until we can find a solution. (cherry picked from commit db4d752) Bug: 1509119 Fixed: 1509779 Change-Id: I83ebbe68b3df81b7550b392b3938752201f0fd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5103029 Auto-Submit: Jack Yammine <jyammine@google.com> Commit-Queue: Jack Yammine <jyammine@google.com> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1234959} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5110322 Cr-Commit-Position: refs/branch-heads/6167@{chromium#218} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
kaidokert
pushed a commit
to youtube/chrobalt_sandbox
that referenced
this pull request
May 18, 2024
Roll Chrome Linux PGO profile from chrome-linux-5735-1683115063-7cee98c08e4beac0bb9df377dea4ecbb9632ed5b.profdata to chrome-linux-5735-1683134587-71adc2eeb2e11c39c372b8217b677236660d61c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m114.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If59084fe56ea75dbf615cc668fe2b523a2a419a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503681 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{chromium#218} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
aarongable
pushed a commit
that referenced
this pull request
May 19, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6478-1716065789-5ecd3179c8bffce133b814c2ed0420da315f3b17-06be92cc58d7cce194a260dd6de241a8c1dd25d4.profdata to chrome-mac-arm-6478-1716071882-4ce33c9fd01d3a89330cef8da7baab3bc417725f-d0db0d9f06d08ce42b7aa6c2625febcc77564f11.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I027d63fdcafdffedd7a93720ac0b698351ae1f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549722 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#218} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXING README typos: