Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make NewRemoteAllocator accept url without devtools/browser/... #817

Merged
merged 5 commits into from May 14, 2021

Commits on May 11, 2021

  1. format allocate_test.go

    ZekeLu committed May 11, 2021
    Copy the full SHA
    98e23a3 View commit details
    Browse the repository at this point in the history
  2. make NewRemoteAllocator accept url without "devtools/browser/..."

    A full websocket debugger URL is something like this:
    ws://127.0.0.1:9222/devtools/browser/120e6fb7-0094-47a2-8b4c-51741797f280
    And the ID part is not static, which requires extra work to get
    the correct URL for NewRemoteAllocator.
    
    This change allows the client to just pass the base URL to
    NewRemoteAllocator. It will send a request to "/json/version"
    to get the full websocket debugger URL.
    
    After the change, the URL with the following formats are accepted:
    * ws://127.0.0.1:9222/
    * http://127.0.0.1:9222/
    
    But "ws://127.0.0.1:9222/devtools/browser/" are not accepted.
    Because it contains "/devtools/browser/" and will be considered
    as a valid websocket debugger URL.
    ZekeLu committed May 11, 2021
    Copy the full SHA
    4fe5615 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Copy the full SHA
    3673c0c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    83892fd View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    33fef11 View commit details
    Browse the repository at this point in the history