Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing nil as res to chromedp.Evaluate() #816

Merged
merged 2 commits into from May 10, 2021
Merged

allow passing nil as res to chromedp.Evaluate() #816

merged 2 commits into from May 10, 2021

Commits on May 8, 2021

  1. allow passing nil as res to chromedp.Evaluate() 

    Sometimes, users just want to call a js function (for example,
window.scrollTo(0, 0)), and don't care about the return value.
So it's not necessary to force res to not be nil.
And it eliminates the case that "undefined" results in an error.
    @ZekeLu
    ZekeLu committed May 8, 2021
    Copy the full SHA
    39a9dc9 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. revert the spelling change to unmarshaling 

    according to https://github.com/golang/go/wiki/Spelling
    @ZekeLu
    ZekeLu committed May 9, 2021
    Copy the full SHA
    d085b08 View commit details
    Browse the repository at this point in the history