Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some of the issues in the Poll action #778

Merged
merged 3 commits into from Apr 27, 2021
Merged

Fix some of the issues in the Poll action #778

merged 3 commits into from Apr 27, 2021

Commits on Apr 27, 2021

  1. ensure the frame is loaded before using it in the Poll action 

    most of the source code is duplicated with the Query action,
so the source code is extracted into a function.
    @ZekeLu
    ZekeLu committed Apr 27, 2021
    Copy the full SHA
    a3559b2 View commit details
    Browse the repository at this point in the history

  2. correct the tests for WithPollingMutation() option 

    The scenario:
1. the js in poll.html will set globalThis.__FOO to 1 with a
10ms timeout;
2. the js function pollMutation() checks the predicate at the very
first run.
When step 2 happens after step 1, pollMutation() will fulfill
without DOM mutation; which will fail the tests.
    @ZekeLu
    ZekeLu committed Apr 27, 2021
    Copy the full SHA
    331df0d View commit details
    Browse the repository at this point in the history

  3. correct the assertion when there is an error

    @ZekeLu
    ZekeLu committed Apr 27, 2021
    Copy the full SHA
    b17375b View commit details
    Browse the repository at this point in the history