Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop retrying for invalid selectors (such as "#a:b") #1303

Merged
merged 1 commit into from Aug 5, 2023
Merged

stop retrying for invalid selectors (such as "#a:b") #1303

merged 1 commit into from Aug 5, 2023

Commits on Aug 5, 2023

  1. stop retrying for invalid selectors (such as "#a:b") 

    It does not make sense to retry the query for invalid selector
because it will always fail.

But the CDP hides the detail error for invalid selector, and only
gives us "DOM Error while querying". We will stop retrying when
we see this error message.
    @ZekeLu
    ZekeLu committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    2f00e19 View commit details
    Browse the repository at this point in the history