Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for Flatpak binaries and ungoogled-chromium #1032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawidpotocki
Copy link

No description provided.

@ZekeLu
Copy link
Member

ZekeLu commented Mar 11, 2022

Thanks for the pull request! But in my opinion, those paths don't have to go into the lib. The users can specify a path that is not built-in easily:

	opts := append(chromedp.DefaultExecAllocatorOptions[:],
		chromedp.ExecPath("path to the browser"),
	)
	allocCtx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)
	defer cancel()
	ctx, cancel := chromedp.NewContext(allocCtx)
	defer cancel()

@dawidpotocki
Copy link
Author

dawidpotocki commented Mar 11, 2022

Well, I saw that snap is included, so why not Flatpak?
Unlike snap it's not used only by Ubuntu.

I'm fine with taking out ungoogled-chromium, but I feel like Flatpak makes sense.

@ZekeLu
Copy link
Member

ZekeLu commented Mar 11, 2022

FYI, chrome is still on flathub-beta and not graduated yet: https://discourse.flathub.org/t/google-chrome-on-flathub-beta/634

I will leave the decision to @kenshaw .

@dawidpotocki
Copy link
Author

dawidpotocki commented Apr 5, 2022

Chrome just got promoted to Flathub stable.
(and yes, I knew it wasn't there when I created the PR)
https://www.flathub.org/apps/details/com.google.Chrome
https://www.flathub.org/apps/details/com.google.ChromeDev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants