Fix issue with pseudo classes #82
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalimBensiali
changed the base branch from
main
to
56-selecting-specific-element-also-applies-pseudostate-to-all-its-descendants
SalimBensiali
changed the base branch from
56-selecting-specific-element-also-applies-pseudostate-to-all-its-descendants
to
main
|
Hi @ghengeveld would love your review of this fix. It is another case of the same issue described and fixed in #45 |
|
Or maybe @shilman ? |
|
Could you add as well |
|
I think we shouldn't apply pseudo style overrides to any pseudo classes that are applied to pseudo elements ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #45