feat: add parameter to configure selector limit #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are also running into this problem with a larger framework and would like to put a quite high limit, performance seems to be fine enough for us with a higher limit (local testing). |
YellowKirby
force-pushed
the
selectorLimit
branch
2 times, most recently
from
211dbb2
to
bd6defd
Compare
YellowKirby
force-pushed
the
selectorLimit
branch
from
bd6defd
to
6ac5955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameworks such as Tailwind can introduce stylesheets with a large number of selectors, and at the moment this addon has a hard 1000-selector limit before it stops iterating.
This PR makes that limit configurable, with the caveat that it might hurt performance. Since we're primarily using this addon for visual regression testing I'd much rather have completeness over performance.
I did notice that this was discussed a bit here so I'd be happy to look into alternative solutions if that comment is still applicable.