New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream changes #8
Conversation
…altunnel#307) * Update node versions in travis.yml * Use xenial as the default build environment
* Add support for tunneling a local HTTPS server. * Return a Promise from localtunnel.
Our server doesn't current use this (AFAIK). We just want to ensure we can deploy a new version of our tunnel which does (and relies on it) without needing to wait for our users to upgrade their package. So I'd be OK with dropping this part.
Sounds like something we could do easily enough I guess? |
Noting that merging this (and releasing) should solve this vulnerability (from using an old version of yargs which has the vulnerable y18n) tangentially related: yargs/y18n#112 |
This makes our fork up-to-date with the latest changes from
localtunnel/localtunnel
.The following modifications remain:
body.cachedUrl
(which the Chromatic localtunnel server provides) as alternative tobody.cached_url
(which localtunnel accepts by default). We have to update our localtunnel server to passcached_url
besidescachedUrl
, so that we can drop this modification.process.env.NODE_TLS_REJECT_UNAUTHORIZED === '0'
as alternative to theallow_invalid_cert
option. We may be able to pass this option in the CLI based on the env var in order to drop this modification.